Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: 9c90a0737b809048b56dfaa9e64b0a35d6609271 https://github.com/openssl/openssl/commit/9c90a0737b809048b56dfaa9e64b0a35d6609271 Author: Richard Levitte <levi...@openssl.org> Date: 2022-07-26 (Tue, 26 Jul 2022)
Changed paths: M Configurations/10-main.conf Log Message: ----------- Configurations/10-main.conf: In the VC-common target, unquote $(CC) Some of the VC-common attributes have values that use `$(CC)`, wrapped with quotes. However, `Configurations/windows-makefile.tmpl` already quotes the `CC` value, like this: CC="{- $config{CC} -}" The interaction between that makefile variable and the attributes using `$(CC)` wrapped with quotes is a command line with the quotes doubled. For example, the value of `$(CPP)` becomes `""cl""`. Strangely enough, this appears to be tolerated, at least on some versions of Windows. However, this has been reported not to be the case. This is fixed by removing the quotes in `Configurations/10-main.conf`, making `Configurations/windows-makefile.tmpl` responsible for proper quoting. Fixes #18823 Reviewed-by: Hugo Landau <hlan...@openssl.org> Reviewed-by: Matt Caswell <m...@openssl.org> (Merged from https://github.com/openssl/openssl/pull/18861) (cherry picked from commit c04b8819161de007cee831dd9e58dde52268da18)