On Dec 7, 2009, at 4:06 PM, Stephen Henson via RT wrote: >> [[email protected] - Thu Dec 03 20:54:44 2009]: >> >> This patch enables the servername, renegotiation and session ticket >> extensions for DTLS. The TLS code is reused and my former separate >> implementation of the renegotiation extension removed. The other >> not yet implemented extensions are disabled. >> > > Thanks. I note that the functions dtls1_send_newsession_ticket and > tl1s_send_newsession_ticket() are very similar. Could we further reduce > code duplication by having one version which checks the version and does > the right thing?
I decided to duplicate it because the header is different for DTLS, and therefore several lenghts and buffer positions differ all across the function. That'd require many checks, and that's probably the reason why all message assembling functions are duplicated for DTLS while the receiving ones are the same. I just noticed that in the submitted patch the declaration of dtls1_send_newsession_ticket() is missing. That'd be: --- ssl/ssl_locl.h 2009-11-09 19:58:50.000000000 +0100 +++ ssl/ssl_locl.h 2009-12-07 11:21:16.000000000 +0100 @@ -949,6 +949,7 @@ void dtls1_stop_timer(SSL *s); int dtls1_is_timer_expired(SSL *s); void dtls1_double_timeout(SSL *s); +int dtls1_send_newsession_ticket(SSL *s); /* some client-only functions */ Regards, Robin ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
