Bodo Moeller wrote:
>
> Ben Laurie <[EMAIL PROTECTED]>:
> > Bodo Moeller:
>
> >> As likely all
> >> systems that declare getsockopt() to take an int * don't have problems
> >> with mixing those types, nothings speaks against doing things right
> >> and use a size_t variable to store the size.
>
> > Except you get a warning when you compile. Which, in my case, at least,
> > means it stops (I use -Werror, and I don't intend to stop).
>
> But the problem is in the system header files, not in the program.
> When those header files are not quite as they should be, warnings can
> be inevitable (on Linux, you cannot compile programs that #include
> <sys/sockets.h> with -pedantic-erros because there's some zero-length
> array, and on Solaris you run across various signedness issues).
> So my suggestion is, don't use compiler options that are that strict,
> and let the compiler print all those annoying warnings instead of
> treating them as errors.
Nah. Sorry. That means I have to read the warnings each time and ensure
they aren't real warnings. I don't care about broken headers in Linux,
because Linux appears to be permanently broken anyway; all that means is
that Linux isn't a suitable platform for cautious programmers.
The question of what setsockopt's arguments "should be" is a different
issue: should be according to who?
> (By the way, several OpenSSL functions still use char * where
> const char * would seem appropriate; e.g.
> SSL_CTX_load_verify_locations; can we just change those [including
> those in the library functions called from there], or are the types
> const-less for compatibility reasons?)
Please change them. We can fight about it afterwards if it causes
problems :-)
Cheers,
Ben.
--
http://www.apache-ssl.org/ben.html
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [EMAIL PROTECTED]
Automated List Manager [EMAIL PROTECTED]
