On Mon, May 22, 2000 at 04:52:12PM -0700, Claus Assmann wrote:
> Attached is a patch for the problem reported earlier. Please let
> me know whether the patch is ok.
...
> > s->client_version has the value 0x0301, but it should have 0x0300
> > according to Stalker.
> --- s3_clnt.c.orig Mon May 22 16:25:01 2000
> +++ s3_clnt.c Mon May 22 16:27:50 2000
> @@ -1341,6 +1341,7 @@
> EVP_PKEY_free(pkey);
> }
>
> + s->client_version=s->version;
> tmp_buf[0]=s->client_version>>8;
> tmp_buf[1]=s->client_version&0xff;
> if (RAND_bytes(&(tmp_buf[2]),SSL_MAX_MASTER_KEY_LENGTH-2) <= 0)
Unfortunately your patch will explicitely break RFC2246:
...
client_version
The latest (newest) version supported by the client. This is
used to detect version roll-back attacks. ...
I have also crosschecked with the latest SSLv3 specifications found at
Netscape and the corresponding paragraph is the same.
Hence, the Stalker implementation also violates SSLv3...
Best regards,
Lutz
--
Lutz Jaenicke [EMAIL PROTECTED]
BTU Cottbus http://www.aet.TU-Cottbus.DE/personen/jaenicke/
Lehrstuhl Allgemeine Elektrotechnik Tel. +49 355 69-4129
Universitaetsplatz 3-4, D-03044 Cottbus Fax. +49 355 69-4153
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [EMAIL PROTECTED]
Automated List Manager [EMAIL PROTECTED]
