Re: cvs commit: openssl/ssl s3_enc.c ssl.h ssl_err.c ssl_lib.c

[Richard Levitte - VMS Whacker]

From: Bodo Moeller <[EMAIL PROTECTED]>

moeller> I don't think it's good to have active assert()s in default
moeller> compilations of libraries -- in particular, libraries for
moeller> multi-threaded programs.  Everywhere else, we define NDEBUG unless an
moeller> appropriate ..._DEBUG preprocessor symbol is defined (otherwise we
moeller> should use -DNDEBUG in all non-debug configurations).  With that
moeller> SSLerr(), the problem will still be noticed when testing, and in
moeller> addition to this the test is active even if NDEBUG is defined.

Then, the right thing would also have been to add a small section at
the beginning of s3_enc.c that defines NDEBUG if SSL_DEBUG (or
something like that) is undefined, wouldn't it?  I'm not saying that
an error shouldn't be returned, however...

-- 
Richard Levitte   \ Spannvägen 38, II \ [EMAIL PROTECTED]
Chairman@Stacken   \ S-168 35  BROMMA  \ T: +46-8-26 52 47
Redakteur@Stacken   \      SWEDEN       \ or +46-709-50 36 10
Procurator Odiosus Ex Infernis                -- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/
Software Engineer, Celo Communications: http://www.celocom.com/

Unsolicited commercial email is subject to an archival fee of $400.
See <http://www.stacken.kth.se/~levitte/mail/> for more info.
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]