Jeffrey Altman wrote: > > > On Tue, Jul 31, 2001 at 12:41:45PM +0100, Ben Laurie wrote: > > > > >>> -typedef struct des_ks_struct > > >>> +typedef struct des_ks > > [...] > > > > >> Surely this deserves an entry in 'CHANGES'? > > > > > It got one, when I committed from the right directory! > > > > +) Rationalise EVP so it can be extended: don't include a union of > > cipher/digest structures, add init/cleanup functions. This also reduces > > the number of header dependencies. > > [Ben Laurie] > > > > I'd had hoped that it would say what might have to be changed in > > applications -- i.e. that des_key_schedule is now a struct > > and no arrary, and that now functions using des_key_schedule > > expect a pointer to the struct where previously they expected > > a pointer to the first element of the array, meaning that > > '&' has to be added when some des_key_schedule typed variable > > is used. > > > > Also doc/crypto/des.pod should be updated accordingly. > > Please be very careful with the changes that are made to DES. The DES > structures and functions from OpenSSL were originally designed by Eric > to be compatible with the MIT Kerberos DES implementation. This has > allowed applications such as C-Kermit to implement both Kerberos and > SSL/TLS (as is needed for Telnet and SSH) by using only the OpenSSL > DES implementation. Changes that result in name conflicts or data > structure conflicts will be a serious problem for application that > require both Kerberos and SSL/TLS. I find it hard to believe that the Kerberos data structures are as broken as the OpenSSL ones were. Are you saying that you use the same data structure for calls to Kerberos DES as to OpenSSL DES? Initialised by the same routines? Or what? Cheers, Ben. -- http://www.apache-ssl.org/ben.html "There is no limit to what a man can do or how far he can go if he doesn't mind who gets the credit." - Robert Woodruff ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [EMAIL PROTECTED] Automated List Manager [EMAIL PROTECTED]
