On Wed, Feb 20, 2002 at 06:45:41PM +0100, Richard Levitte - VMS Whacker wrote:
[...]
> If you look in conf.h, you'll also see why it includes e_os.h: an
> #ifndef NO_FP_API.
>
> BTW, in 0.9.7-dev, we have the same (or almost, it depends on
> OPENSSL_NO_FP_API) #ifndef, but that one is meaningless, since
> OPENSSL_NO_FP_API is defined in e_os.h.
>
> Suggestion on how to solve this? One that I can think of is to remove
> the conditional and just let CONF_load_fp() (and NCONF_load_fp()) be
> declared even if they aren't in the library. That's ugly, but
> workable.
It certainly is a lot less ugly than forcing e_os.h upon applications
that don't request it, so I think we should simply make the prototype
unconditional. Hm, other header files have similarly #ifndef-ed
prototypes too -- they just don't include e_os.h, so this should be OK
for conf.h as well.
In 0.9.6-stable, conf.h also requires e_os.h to get MS_FAR defined.
You simply removed this in 0.9.7-dev, so I figure we can do the same
in 0.9.6-stable:
revision 1.19
date: 2001/02/22 17:41:15; author: levitte; state: Exp; lines: +9 -9
CONF_METHOD is one of the few places where you find MS_FAR. I can't
really see why we need to define these function pointers with MS_FAR
if it's not done cosistently everywhere.
If we decide to support MS_FAR modifiers, it's better to have the
named something more unique for OpenSSL and to define them in e_os2.h.
The occurrences of MS_FAR in conf.h were new with 0.9.6, so certainly
no legacy applications will be affected by removing them. On all
platforms actually used in real life, MS_FAR has an empty definition
anyway.
Summary: We should remove '#include <openssl/e_os.h>' and 'MS_FAR'
from conf.h, then everything should be fine (or at least consistent
with the rest of OpenSSL).
--
Bodo M�ller <[EMAIL PROTECTED]>
PGP http://www.informatik.tu-darmstadt.de/TI/Mitarbeiter/moeller/0x36d2c658.html
* TU Darmstadt, Theoretische Informatik, Alexanderstr. 10, D-64283 Darmstadt
* Tel. +49-6151-16-6628, Fax +49-6151-16-6036
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [EMAIL PROTECTED]
Automated List Manager [EMAIL PROTECTED]
