Bodo Moeller wrote:
> > * crypto/bio/bss_bio.c now checks SSIZE_MAX, and in the visual c++
> > limits.h this won't get defined unless one defines _POSIX_. Should this
> > definition go into e_os.h or is it ok to simply insert it here prior to
> > the inclusion of limits.h?
> 
> If SSIZE_MAX is not defined, we use INT_MAX instead.  Why worry about
> it?

Sorry for not being clearer. The reason I (or my compiler rather) was
worrying about it is that it's actually a case of _INT_MAX being used
rather than INT_MAX. MSVC doesn't define the former anywhere and thus
either needs SSIZE_MAX defined, which it can get from limits.h if
_POSIX_ is defined, or the ability to fall back to using INT_MAX (as
opposed to _INT_MAX), which it gets from limits.h regardless of whether
_POSIX_ has been defined or not.

I simply added the following to make it compile:

Index: bss_bio.c
===================================================================
RCS file: /usr/local/cvsroot/libraries/openssl/crypto/bio/bss_bio.c,v
retrieving revision 1.29.2.3
diff -u -r1.29.2.3 bss_bio.c
--- bss_bio.c   14 Feb 2002 16:06:19 -0000      1.29.2.3
+++ bss_bio.c   1 Mar 2002 17:26:05 -0000
@@ -13,6 +13,10 @@
 #endif
 
 #include <assert.h>
+/* MSVC only defines SSIZE_MAX when building for Posix compatibility */
+#if defined(WIN32)
+# define _POSIX_
+#endif
 #include <limits.h>
 #include <stdlib.h>
 #include <string.h>

Sorry about the confusion,

//oscar
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to