[resent so that RT picks up the patch]
On Thu, 27 Jun 2002, Richard Levitte via RT wrote: > > [[EMAIL PROTECTED] - Thu Jun 27 11:32:12 2002]: > > > x509.h : This is the change I'm genuinely unsure about. x509.h > > includes > > asn1.h, but both x509/x_all.c and x509v3/v3_bitst.c reference (via > > macros) > > struct ASN1_ITEM_st, which is defined not in asn1.h but in asn1t.h. > > Since both files include x509.h, which includes asn1.h, and since > > asn1t.h > > includes asn1.h, I've changed x509.h to include asn1t.h instead of > > asn1.h. > > Someone who knows the code better may be able to come up with a > better > > solution. > > I'm not sure why this should be a problem. Have you gotten some > kind off errors or warnings because if the inclusion of asn1.h > instead of asn1t.h? You see, asn1.h does define ASN1_ITEM and > declares the extense of struct ASN1_ITEM_st. Unless the .c files > you mention are actually poking in that structure or need to know > it's size, there's no reason to define the structure. I haven't had > any problems in my builds (on Linux and Solaris)... I get the following errors in x_all.c: Error E2450 .\crypto\x509\x_all.c 72: Undefined structure 'ASN1_ITEM_st' in function X509_verify Error E2450 .\crypto\x509\x_all.c 72: Undefined structure 'ASN1_ITEM_st' in function X509_verify ...and the same errors in X509_REQ_verify, X509_CRL_verify, NETSCAPE_SPKI_verify, X509_sign, etc. This appears to be related to the ASN1_ITEM_rptr macro, though why this should be, I don't know. There's quite a depth of macros there, though, so maybe I missed something. I'll take a closer look. > Eeeeeep! Not good to do that without making the same change to > VC-32.pl and so on as you did to BC-32.pl... I'll see if I've the > energy to make an effort there... Attached, the patch to do this, as well as to make the appropriate change in do_masm.bat. I would have done this originally, but since the commit messages for x86nasm.pl indicating nasm wasn't working anyway, I figured no-one could be using Visual C with nasm :-) -- Jon Bright Lead Programmer, Silicon Circus Ltd. http://www.siliconcircus.com ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [EMAIL PROTECTED] Automated List Manager [EMAIL PROTECTED]
