[openssl.org #303] openssl-engine-0.9.6g bug in apps/rand.c

[[EMAIL PROTECTED] via RT]

Hello every body.
Thanks a lot for your nice job, meanwhile there a little bug in
'apps/rand.c'

Operating system: ALL
OpenSsl: 0.9.6g engine


The original code, from line 45
       while (!badopt && argv[++i] != NULL)
                {
                if (strcmp(argv[i], "-out") == 0)
                        {
                        if ((argv[i+1] != NULL) && (outfile == NULL))
                                outfile = argv[++i];
                        else
                                badopt = 1;
                        }
                if (strcmp(argv[i], "-engine") == 0)
                        {
                        if ((argv[i+1] != NULL) && (engine == NULL))
                                engine = argv[++i];
                        else
                                badopt = 1;
                        }
                else if (strcmp(argv[i], "-rand") == 0)

The code as I think it should be
       while (!badopt && argv[++i] != NULL)
                {
                if (strcmp(argv[i], "-out") == 0)
                        {
                        if ((argv[i+1] != NULL) && (outfile == NULL))
                                outfile = argv[++i];
                        else
                                badopt = 1;
                        }
                else if (strcmp(argv[i], "-engine") == 0)
                        {
                        if ((argv[i+1] != NULL) && (engine == NULL))
                                engine = argv[++i];
                        else
                                badopt = 1;
                        }
                else if (strcmp(argv[i], "-rand") == 0)


Without the 'else' condition in line 54, when we give a '-out outfile'
argument, we always get a 'badopt' error and the usage message.

     Thanks for integrating this correction in the next version.
          Jean-Etienne SCHWARTZ

mail: [EMAIL PROTECTED]


______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]