In message <[EMAIL PROTECTED]> on Mon, 4 Aug 2003 11:40:29 +0200 (MEST), Peter 
Sylvester <[EMAIL PROTECTED]> said:

Peter.Sylvester> > > Why does engines insist to compile the engines
Peter.Sylvester> > > with no-engine. 
Peter.Sylvester> > 
Peter.Sylvester> > We generally do this because we don't have a
Peter.Sylvester> > mechanism for conditionals in Makefiles.
Peter.Sylvester> 
Peter.Sylvester> hm, pushing a model makefile through a C
Peter.Sylvester> preprocessor?

*bleargh*  Uhmm, I've once seen a Makefile being heavily sabotaged by
a C preprocessor that added spaces arond tokens...  Unfortunately I
can't reproduce it, the compiler has become better in later versions,
but that has given me a sound avertion to such methods.

Peter.Sylvester> > >   evp/c_all_c.c does not compile, the program
Peter.Sylvester> > > seems useless anyway, it just includes engine.h
Peter.Sylvester> > > unconditionally.
Peter.Sylvester> > 
Peter.Sylvester> > All headers are included unconditionally - this is
Peter.Sylvester> > so we don't get dependency flap between the
Peter.Sylvester> > developers.
Peter.Sylvester> 
Peter.Sylvester> If engines are not defined, the engine.h does not
Peter.Sylvester> like to be included since it has
Peter.Sylvester> 
Peter.Sylvester> #ifdef OPENSSL_NO_ENGINE
Peter.Sylvester> #error ENGINE is disabled.
Peter.Sylvester> #endif
Peter.Sylvester> 
Peter.Sylvester> is this intended?

Yes.  The inclusion of engine.h should really be preceeded by an
inclusion of openssl/opensslconf.h or openssl/e_os2.h (if not already
done, maybe recursively) and wrapped in a #ifndef OPENSSL_NO_ENGINE
.. #endif.

I thought I had already fixed that...

-- 
Richard Levitte   \ Tunnlandsv�gen 3  \ [EMAIL PROTECTED]
[EMAIL PROTECTED]  \ S-168 36  BROMMA  \ T: +46-8-26 52 47
                    \      SWEDEN       \ or +46-708-26 53 44
Procurator Odiosus Ex Infernis                -- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/

Unsolicited commercial email is subject to an archival fee of $400.
See <http://www.stacken.kth.se/~levitte/mail/> for more info.
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to