Richard Levitte - VMS Whacker wrote: > In message <[EMAIL PROTECTED]> on Sat, 13 Sep 2003 18:57:57 +0200 (CEST), "Ben > Laurie" <[EMAIL PROTECTED]> said: > > ben> OpenSSL CVS Repository > ben> http://cvs.openssl.org/ > ben> ____________________________________________________________________________ > ben> > ben> Server: cvs.openssl.org Name: Ben Laurie > ben> Root: /e/openssl/cvs Email: [EMAIL PROTECTED] > ben> Module: openssl Date: 13-Sep-2003 18:57:57 > ben> Branch: OpenSSL-fips-0_9_7-stable Handle: 2003091317575600 > ben> > ben> Modified files: (Branch: OpenSSL-fips-0_9_7-stable) > ben> openssl Configure > ben> > ben> Log: > ben> Add a debug flag. > ben> > ben> Summary: > ben> Revision Changes Path > ben> 1.314.2.85.2.4+12 -1 openssl/Configure > ben> ____________________________________________________________________________ > ben> > ben> patch -p0 <<'@@ .' > ben> Index: openssl/Configure > ben> ============================================================================ > ben> $ cvs diff -u -r1.314.2.85.2.3 -r1.314.2.85.2.4 Configure > ben> --- openssl/Configure 4 Sep 2003 10:22:12 -0000 1.314.2.85.2.3 > ben> +++ openssl/Configure 13 Sep 2003 16:57:56 -0000 1.314.2.85.2.4 > ben> @@ -10,7 +10,7 @@ > ben> > ben> # see INSTALL for instructions. > ben> > ben> -my $usage="Usage: Configure [no-<cipher> ...] [-Dxxx] [-lxxx] [-Lxxx] > [-fxxx] [-Kxxx] [no-engine] [no-hw-xxx|no-hw] [[no-]threads] [[no-]shared] > [[no-]zlib|zlib-dynamic] [no-asm] [no-dso] [no-krb5] [386] [fips] [--prefix=DIR] > [--openssldir=OPENSSLDIR] [--with-xxx[=vvv]] [--test-sanity] os/compiler[:flags]\n"; > ben> +my $usage="Usage: Configure [no-<cipher> ...] [-Dxxx] [-lxxx] [-Lxxx] > [-fxxx] [-Kxxx] [no-engine] [no-hw-xxx|no-hw] [[no-]threads] [[no-]shared] > [[no-]zlib|zlib-dynamic] [no-asm] [no-dso] [no-krb5] [386] [fips] [debug] > [--prefix=DIR] [--openssldir=OPENSSLDIR] [--with-xxx[=vvv]] [--test-sanity] > os/compiler[:flags]\n"; > ben> > ben> # Options: > ben> # > ben> @@ -630,6 +630,7 @@ > ben> my $default_ranlib; > ben> my $perl; > ben> my $fips=0; > ben> +my $debug=0; > ben> > ben> my $no_ssl2=0; > ben> my $no_ssl3=0; > ben> @@ -808,6 +809,10 @@ > ben> $fips=1; > ben> $openssl_other_defines.="#define OPENSSL_FIPS\n"; > ben> } > ben> + elsif (/^debug$/) > ben> + { > ben> + $debug=1; > ben> + } > ben> elsif (/^rsaref$/) > ben> { > ben> # No RSAref support any more since it's not needed. > ben> @@ -1167,6 +1172,12 @@ > ben> { > ben> # $rmd160_obj=$rmd160_enc; > ben> $cflags.=" -DRMD160_ASM"; > ben> + } > ben> + > ben> +if ($debug) > ben> + { > ben> + $cflags.=" -g"; > ben> + $cflags=~s/-fomit-frame-pointer//; > ben> } > ben> > ben> # "Stringify" the C flags string. This permits it to be made part of a > string > ben> @@ . > > Hmm, shouldn't "debug" do more? I've been thinking about adding that > for a while, but it does demand a large amount of work to have it > perfect (for some value of "perfect" :-)). > > We currently have a debug flag for ./config (-d), which basically > prefixes "debug-" to the guessed target. We don't have debug support > for all fo them (out of slopiness, I guess :-/), but that's a > different thing (and also demands a lot of work).
Exactly, this was a quick fix that works on any gcc-based platform. I figured we could revise it over time. I also figured that adding debug- for all those platforms is just plain sucky. Perhaps we should make it use the debug- target if it exists and guess otherwise? Cheers, Ben. -- http://www.apache-ssl.org/ben.html http://www.thebunker.net/ "There is no limit to what a man can do or how far he can go if he doesn't mind who gets the credit." - Robert Woodruff ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [EMAIL PROTECTED] Automated List Manager [EMAIL PROTECTED]
