[openssl.org #778] FreeBSD 5.1: memory leak with no /dev/crypto

[George Mitchell via RT]

On FreeBSD 5.1 with no /dev/crypto, "make" followed by "make test"
results in a plethora of messages of the following ilk:

[11:18:39]   347 file=eng_lib.c, line=71, thread=2756, number=88, address=0817C3
00
[11:18:39]  1717 file=eng_lib.c, line=71, thread=2756, number=88, address=0817C9
80
176 bytes leaked in 2 chunks
[11:18:39]   347 file=eng_lib.c, line=71, thread=2757, number=88, address=0817C3
00
[11:18:39]  1717 file=eng_lib.c, line=71, thread=2757, number=88, address=0817C9
80
176 bytes leaked in 2 chunks

The following patch corrects the problem:

*** crypto/engine/hw_cryptodev.c.orig   Thu Jan 23 00:10:07 2003
--- crypto/engine/hw_cryptodev.c        Fri Nov 21 20:52:09 2003
***************
*** 1055,1060 ****
--- 1055,1061 ----
        if (engine == NULL)
                return;
        if ((fd = get_dev_crypto()) < 0)
+               ENGINE_free (engine);
                return;
  
        /*
***************
*** 1062,1067 ****
--- 1063,1069 ----
         */
        if (ioctl(fd, CIOCASYMFEAT, &cryptodev_asymfeat) == -1) {
                close(fd);
+               ENGINE_free (engine);
                return;
        }
        close(fd);


-- George Mitchell

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]