[EMAIL PROTECTED] - Thu Nov 27 09:23:09 2003]: > This patch adds support for the NetWare OS to OpenSSL 0.9.7. After > applying this patch, the instructions for building for NetWare can be > found in the "INSTALL.NW" file in the root directory. This patch > attempts to minimize impact on other platforms through the judicious > use > of the preprocessor guard "OPENSSL_SYS_NETWARE". It does introduce one > new general purpose function "ERR_free_state_table" which we found > useful when cleaning up threads.
I'm not sure I understand the need for ERR_free_state_table(). It seems to me that ERR_remove_state() performs the same operation, but makes sure that only the state of the current thread is cleaned (int_thread_del_item() will free that whole hash table when the last thread runs it). To be perfectly clear, it seems to me like ERR_free_state_table() would be disastrous to use in a threaded environment, or at least very potentially so. I will therefore reject the changes to crypto/err/err. c, crypto/err/err.h and util/libeay.num. There are a few more issues, although comparatively minor: 1. Do you know that crypto/des/read_pwd.c isn't used at all any more? It can safely be ignored. I will therefore reject your changes to that file. 2. In crypto/mdc2/mdc2test.c, I notice you removed the call to EVP_MD_CTX_cleanup() on line 142. Was there a reason for that, or is it just a typo? 3. Will you help us maintain these changes in future versions of OpenSSL, or is there a risk that the new files will age quickly? > I have applied the patch to the latest 0.9.7c source and built for > both > NetWare and Windows. The test suite runs correctly on both platforms > with the patch applied. > > I understand that active development on the 0.9.7 code is limited. > These changes, however, have minimal impact on existing code and I > hope > you will consider them. If the patch is not accepted for 0.9.7, I > request that this patch file be added to the "Contributions" page in > the > same manner as the 0.9.6 NetWare patch. I will place the patch kit, with the rejected changes removed, in the contribution directory for now. I'm keeping this ticket open and will await your answer to my issues. I will also check with the other developpers if they have some issues with this change. After that, I will reconsider the application of the change. I'm making no promisses, though. -- Richard Levitte [EMAIL PROTECTED] ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [EMAIL PROTECTED] Automated List Manager [EMAIL PROTECTED]
