In message <[EMAIL PROTECTED]> on Thu, 27 Jan 2005 12:25:15 +0100, Nils Larsch <[EMAIL PROTECTED]> said:
nils.larsch> wouldn't it be cleaner to change the first parameter of nils.larsch> the local function load_iv from "unsigned char **" to nils.larsch> "char **" (and than change "from" in load_iv to "char" as nils.larsch> well) ? The fact that the first parameter of load_iv is nils.larsch> an "unsigned char **", and not just a "char **", is nils.larsch> nowhere used and hence this workaround is superfluous nils.larsch> (and a bit ugly ;-) I agree on all counts, and would add that since the first argument to load_iv() clearly points at text (hex code), it should conceptually be char instead of unsigned char. I've committed the change. Thanks. Cheers, Richard ----- Please consider sponsoring my work on free software. See http://www.free.lp.se/sponsoring.html for details. -- Richard Levitte [EMAIL PROTECTED] http://richard.levitte.org/ "When I became a man I put away childish things, including the fear of childishness and the desire to be very grown up." -- C.S. Lewis ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [EMAIL PROTECTED]
