[PATCH] ENGINE_set_default_DSA() bug fix

[Jonathon Green]

Hi List,

There's a bug in ENGINE_set_default_DSA() which
prevents an engine from being set as the default DSA
implementation. The 'setdefault' parameter of the
engine_table_register() call is 0 rather than 1, you
can check against the RSA engine table implementation
to verify this.

This patch is against
openssl-0.9.8-stable-SNAP-20050908, however I've had a
look at the 0.9.7g source and the bug's there too.

I've tested this patch on AIX 5.1, RedHat 9 and Win32.

Regards,

Jon.



        

        
                
____________________________________________________ 
Do you Yahoo!? 
The New Yahoo! Movies: Check out the Latest Trailers, Premiere Photos and full 
Actor Database. 
http://au.movies.yahoo.com
diff -ur openssl-0.9.8-stable-SNAP-20050908_orig/crypto/engine/tb_dsa.c 
openssl-0.9.8-stable-SNAP-20050908/crypto/engine/tb_dsa.c
--- openssl-0.9.8-stable-SNAP-20050908_orig/crypto/engine/tb_dsa.c      
2005-09-09 04:18:23.000000000 +1000
+++ openssl-0.9.8-stable-SNAP-20050908/crypto/engine/tb_dsa.c   2005-09-09 
04:17:57.000000000 +1000
@@ -92,7 +92,7 @@
        {
        if(e->dsa_meth)
                return engine_table_register(&dsa_table,
-                               engine_unregister_all_DSA, e, &dummy_nid, 1, 0);
+                               engine_unregister_all_DSA, e, &dummy_nid, 1, 1);
        return 1;
        }