Re: [openssl.org #1233] Invalid makefile created on Win32 using mk1mf.pl

[Steve Sonntag]

Your patch corrected the problem, thank you >>> On 01-Nov-05 at 2:29 am, in message <[EMAIL PROTECTED]>, [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] - Tue Nov  1 10:15:07 2005]: > The fix is: > > s/chop/chomp/ I don't agree, as chomp won't take away the ending space when the variable does get a value.  Try the following patch for size and tell me how that worked for you: cvs diff: Diffing util Index: util/mk1mf.pl =================================================================== RCS file: /e/openssl/cvs/openssl/util/mk1mf.pl,v retrieving revision 1.41.2.14 diff -u -r1.41.2.14 mk1mf.pl --- util/mk1mf.pl24 Apr 2005 02:14:25 -00001.41.2.14 +++ util/mk1mf.pl1 Nov 2005 09:27:06 -0000 @@ -766,7 +766,7 @@ local(*OUT,$tmp,$t); $files =~ s/\//$o/g if $o ne '/'; -$ret="$var="; +$ret="$var="; $n=1; $Vars{$var}.=""; foreach (split(/ /,$files)) @@ -796,7 +796,7 @@ $Vars{$var}.="$t "; $ret.=$t; } -chop($ret); +$ret =~ s/\s*$//; $ret.="\n\n"; return($ret); } cvs diff: Diffing util/pl -- Richard Levitte [EMAIL PROTECTED] ______________________________________________________________________ OpenSSL Project                                 http://www.openssl.org Development Mailing List                       openssl-dev@openssl.org Automated List Manager                           [EMAIL PROTECTED]