Re: [openssl.org #1339] mkdef.pl

[Peter Sylvester]

The problem is that a backslash may be followed by a \r


can use an optional \r.


Andy Polyakov via RT wrote:

I have send a patch to openssl-users which I attach. Of course, instead of \s* one

my previous messaqge about mkdef.pl is wrong. Although the indicated code
can still loop, the read error seems to be this one

Could you elaborate on problem itself?

or
            if (/\\\s*$/) {
                chomp; # remove eol
                chop; # remove ending backslash
                $line = $_;
                next;
            }

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           [EMAIL PROTECTED]

As I fail to see why is it an issue. I mean any character following backlash disqualifies the latter as line continuation and \\\s would cause compiler syntax error... A.

--

To verify the signature, see http://edelpki.edelweb.fr/ Cela vous permet de charger le certificat de l'autorité; die Liste mit zurückgerufenen Zertifikaten finden Sie da auch.

diff -purN openssl-0.9.8b/util/mkdef.pl openssl-0.9.8b+S/util/mkdef.pl
--- openssl-0.9.8b/util/mkdef.pl	2006-01-02 15:08:22.000000000 +0100
+++ openssl-0.9.8b+S/util/mkdef.pl	2006-06-04 15:23:22.451088000 +0200
@@ -445,9 +445,9 @@ sub do_defs
 				$line = '';
 			}
 
-			if (/\\$/) {
-				chomp; # remove eol
-				chop; # remove ending backslash
+			if (s/\\\s*$//) {
+				#chomp; # remove eol
+				#chop; # remove ending backslash
 				$line = $_;
 				next;
 			}
diff -purN openssl-0.9.8b/util/mkfiles.pl openssl-0.9.8b+S/util/mkfiles.pl
--- openssl-0.9.8b/util/mkfiles.pl	2005-04-27 18:27:14.000000000 +0200
+++ openssl-0.9.8b+S/util/mkfiles.pl	2006-06-04 15:19:19.251316000 +0200
@@ -88,9 +88,9 @@ while (<IN>)
 		($s,$b)=($1,$2);
 		for (;;)
 			{
-			if ($b =~ /\\$/)
+			if ($b =~ s/\\\s*$//)
 				{
-				chop($b);
+				#chop($b);
 				$o.=$b." ";
 				$b=<IN>;
 				chop($b);

smime.p7s
Description: S/MIME Cryptographic Signature