On Sun, Jul 30, 2006 at 11:10:13AM +0200, Jean-Marc Desperrier wrote:
> Klaus Weidner wrote:
> >[...] - please let me know if you have issues with the
> >bugfix, [...]
> >
> >The following patch uses the ANSI C setvbuf(3) function [...]
> >
> >+            {
> >+            if (bufsize != NULL)
> >+                    setvbuf(stdin, (char *)NULL, _IONBF, 0);
> >             BIO_set_fp(in,stdin,BIO_NOCLOSE);
> >+            }

> There's at least clearly an issue about testing the availability of the 
> setvbuf call before trying to compile it in.
> It's not because it's ANSI that it will be available on every system 
> openssl runs on.

Good point, I guess it isn't safe to count on ANSI compliance. I've
searched the rest of the code, and apps/apps.c already uses setvbuf with
no special conditional handling, so the patch shouldn't introduce any new
compatibility problems.

-Klaus
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to