I wouldn't have thought so no. The more garbage that gets written the
better, provided it gets written to the right place that is.

FWIW. There's a measurable performance increase reverting that to memset()
and adding tests to ensure that the compiler hasn't in fact optimized it
away.

Peter




                                                                       
             Gerrit                                                    
             Bruchhäuser                                             
             <[EMAIL PROTECTED]                                          To
             ro.com>                   [email protected]         
             Sent by:                                                   cc
             owner-openssl-dev                                         
             @openssl.org                                          Subject
                                       crypto/mem_clr.c is not thread safe
                                                                       
             20/06/07 05:02 PM                                         
                                                                       
                                                                       
             Please respond to                                         
                openssl-dev                                            
                                                                       
                                                                       




Hello,

  I made few tests with Intel Thread Check. The following result came up:

crypto/mem_clr.c: [OPENSSL_cleanse]

             Memory read at [...] conflicts with a prior memory write at
[...] (flow
dependence)


Maybe 'OPENSSL_cleanse' should be protected with a mutex?

BR,
Gerrit
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [email protected]
Automated List Manager                           [EMAIL PROTECTED]


______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [email protected]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to