[openssl.org #1615] [PATCH] Using uninitialized value "(c).q"

[via RT]

Hi team,

 

I suggest updating the file crypto/asn1/a_set.c, as follows:

219c219

<                       asn1_add_error(*pp,(int)(c.q- *pp));

---

>                       asn1_add_error(*pp,(int)(c.p - *pp));

 

The function asn1_add_error() receives in its second argument the c.q variable. 
It’s a local variable, but this one does not seem initialized previously in 
this function. 

I think it is a typo mistake and the correct variable is c.p (instead of c.q).

 

Thanks

Eric

 

Hi team,   I suggest updating the file crypto/asn1/a_set.c, as follows: 219c219 <                       asn1_add_error(*pp,(int)(c.q- *pp)); --- >                       asn1_add_error(*pp,(int)(c.p - *pp));   The function asn1_add_error() receives in its second argument the c.q variable. It’s a local variable, but this one does not seem initialized previously in this function. I think it is a typo mistake and the correct variable is c.p (instead of c.q).   Thanks Eric