Dr. Stephen Henson wrote:
  OpenSSL CVS Repository
  http://cvs.openssl.org/
  ____________________________________________________________________________

  Server: cvs.openssl.org                  Name:   Dr. Stephen Henson
  Root:   /v/openssl/cvs                   Email:  [EMAIL PROTECTED]
  Module: openssl                          Date:   10-May-2008 01:17:51
  Branch: OpenSSL_0_9_7-stable             Handle: 2008051000175100

  Modified files:           (Branch: OpenSSL_0_9_7-stable)
    openssl/crypto/stack    safestack.h

  Log:
    Fix from head.

  Summary:
    Revision    Changes     Path
    1.33.2.5    +1  -1      openssl/crypto/stack/safestack.h
  ____________________________________________________________________________

  patch -p0 <<'@@ .'
  Index: openssl/crypto/stack/safestack.h
  ============================================================================
  $ cvs diff -u -r1.33.2.4 -r1.33.2.5 safestack.h
  --- openssl/crypto/stack/safestack.h  14 May 2005 12:59:05 -0000      1.33.2.4
  +++ openssl/crypto/stack/safestack.h  9 May 2008 23:17:51 -0000       1.33.2.5
  @@ -170,7 +170,7 @@
   #define SKM_sk_push(type, st,val) \
        sk_push(st, (char *)val)
   #define SKM_sk_unshift(type, st,val) \
  -     sk_unshift(st, val)
  +     sk_unshift(st, (char *)val)
   #define SKM_sk_find(type, st,val) \
        sk_find(st, (char *)val)
   #define SKM_sk_delete(type, st,i) \

Arg! Surely the correct fix is to make sk_unshift(), et al, take a void * instead of these casts all over the place?

--
http://www.apache-ssl.org/ben.html           http://www.links.org/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to