On Friday 30 May 2008 09:52:40 Ben Laurie wrote: > Dr. Stephen Henson wrote: > > - if (len == -1) > > + if ((len == -1) && !(attrtype & MBSTRING_FLAG)) > > I do wish you wouldn't use these extra brackets around comparison > operators. > > if (len == -1 && !(attrtype & MBSTRING_FLAG)) > > works just fine and is consistent with most of the rest of the code, and > the rest of the world.
I find Steve's version more readable. The object of the exercise is not to confront the reader with code that reminds them what the precedence of C operators are. Nor is it to require the reader to know those operators so well that they can spot code that looks right but is in fact wrong. Cheers, Geoff ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [EMAIL PROTECTED]
