> A few initial comments. > > The copyright notice in srp.c gives the impression Eric Young wrote that file... I'm assuming he didn't and it > is a combination of work from other files in apps he did write.
I believe that is the case. I'll update the copyright notice in the next version of the patch. > The indentation in srp.c (perhaps as a result) is very inconsistent. > > Indentation in other files doesn't follow the "standard" of the rest of OpenSSL (well most of it). > > In a couple of files the low level SHA1 digest API is used directly. > That should be avoided because it precludes use of ENGINEs in future. > Use EVP instead. Thanks for the comments - I will make the suggested fixes and send an updated patch early next week. Tom ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [EMAIL PROTECTED]
