Jivin Green, Paul lays it down ... > David McCullough proposed the following patch to > crypto/engine/eng_cryptodev.c: > > (extracted from a larger change set): > > @@ -428,7 +428,7 @@ cryptodev_init_key(EVP_CIPHER_CTX *ctx, const > unsigned char *key, > if ((state->d_fd = get_dev_crypto()) < 0) > return (0); > > - sess->key = (unsigned char *)key; > + sess->key = (caddr_t)key; > sess->keylen = ctx->key_len; > sess->cipher = cipher; > > Please be aware that the "caddr_t" (core(!) addr) data type is not > included in the POSIX-2001 standard(1). My copy of SuSE Linux make it > visible in sys/types.h under the control of the _BSD_SOURCE macro. If > you are going to use this data type in OpenSSL, you should ensure that > it is defined by OpenSSL if the standard headers do not already define > it. IMHO, a better solution would be to use only POSIX data types. > > (1) http://www.opengroup.org/onlinepubs/009695399/toc.htm
Agreed, I would normally use it, however eng_cryptodev was already using caddr_t in a few places, and the "cryptodev.h" file defines the kernel API, and it uses caddr_t. Other than changing the kernel API I don't see a "nice" way to avoid using caddr_t, but I am open to suggestions :-) Cheers, Davidm -- David McCullough, david_mccullo...@securecomputing.com, Ph:+61 734352815 McAfee - SnapGear http://www.snapgear.com http://www.uCdot.org ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
