On Fri, Sep 04, 2009, Michael Txen wrote: > On Sep 4, 2009, at 5:16 PM, Stephen Henson via RT wrote: > >>> [seggelm...@fh-muenster.de - Fri Sep 04 13:28:50 2009]: >>> >>> >>> On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote: >>> >>>>> [seggelm...@fh-muenster.de - Fri Sep 04 09:39:52 2009]: >>>>> >>>>> >>>>> Still wrong casts....I hope that's it now.... >>>>> >>>> >>>> A fair number of the casts seem to be unnecessary for example in >>>> RAND_bytes(), OPENSSL_malloc() and HMAC(). Do you get warnings on your >>>> system without them? >>> >>> I used the same example in a server/client testprogram and compiled it >>> with the g++ compiler to be very pedantic. The regular gcc doesn't >>> complain if there are none at all, but the g++ is nagging about >>> missing casts. >>> >> >> Well if you compile as C++ you end up needling lots of unnecessary >> casts. You should really compile with one of the "debug-foo" names for >> you platform e.g. debug-steve64. If it works without any warnings on >> that it's a good sign, though some of the more esoteric platforms can >> still complain. >> >> The $gcc_devteam_warn options should be used as a minimum. > OK. So, do you want another version of Robins patch? >
No thanks, made the few minor changes myself. Steve. -- Dr Stephen N. Henson. OpenSSL project core developer. Commercial tech support now available see: http://www.openssl.org ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
