[openssl.org #2241] [PATCH] bug in dsa_priv_decode() in OpenSSL1.0

[Artemy Lebedev via RT]

Hi,

During our project migrating to the version 1.0.0 I have discovered an
obvious coding bug:

--- openssl-1.0.0/crypto/dsa/dsa_ameth.c Fri Jan 22 22:17:29 2010
+++ merge/crypto/dsa/dsa_ameth.c Tue Apr 20 10:21:50 2010
@@ -209,7 +209,7 @@
if (*p == (V_ASN1_SEQUENCE|V_ASN1_CONSTRUCTED))
{
ASN1_TYPE *t1, *t2;
- if(!(ndsa = d2i_ASN1_SEQUENCE_ANY(NULL, &p, pklen)));
+ if(!(ndsa = d2i_ASN1_SEQUENCE_ANY(NULL, &p, pklen)))
goto decerr;
if (sk_ASN1_TYPE_num(ndsa) != 2)
  goto decerr;

Best Regards,
Artyom Lebedev.

Hi,

During our project migrating to the version 1.0.0 I have discovered an obvious coding bug:

--- openssl-1.0.0/crypto/dsa/dsa_ameth.c Fri Jan 22 22:17:29 2010
+++ merge/crypto/dsa/dsa_ameth.c Tue Apr 20 10:21:50 2010
@@ -209,7 +209,7 @@
if (*p == (V_ASN1_SEQUENCE|V_ASN1_CONSTRUCTED))
{
ASN1_TYPE *t1, *t2;
- if(!(ndsa = d2i_ASN1_SEQUENCE_ANY(NULL, &p, pklen)));
+ if(!(ndsa = d2i_ASN1_SEQUENCE_ANY(NULL, &p, pklen)))
goto decerr;
if (sk_ASN1_TYPE_num(ndsa) != 2)
  goto decerr;

Best Regards,

Artyom Lebedev.