Hi all,

During a port of OpenSSL I saw the following message during the build:

crypto/bio/bss_dgram.c:343:5: warning: "OPENSSL_USE_IVP6" is not defined

Well, of course, it isn't defined because it is spelled incorrectly.
Should be OPENSSL_USE_IPV6 as used everywhere else. What I am actually
surprised about is that this typo was introduced in the IPv6 patch set
introduced back in Jan. 2010 and this hasn't been caught or fixed yet.
I guess people don't check warnings anymore :(.

The patch is attached and is included here:

diff -ur openssl/crypto/bio/bss_dgram.c openssl-work/crypto/bio/bss_dgram.c
--- openssl/crypto/bio/bss_dgram.c      2010-01-07 05:42:39.000000000 -0500
+++ openssl-work/crypto/bio/bss_dgram.c 2010-12-28 15:37:24.726625000 -0500
@@ -340,7 +340,7 @@

                if (data->peer.sa.sa_family == AF_INET)
                        peerlen = sizeof(data->peer.sa_in);
-#if OPENSSL_USE_IVP6
+#if OPENSSL_USE_IPV6
                else if (data->peer.sa.sa_family == AF_INET6)
                        peerlen = sizeof(data->peer.sa_in6);
 #endif

Not a stellar contribution, but it gets rid of a warning message and
probably prevents a random breakage when using IPv6 :)

-- 
Mike

Attachment: bss_dgram_ipv6_typo.patch
Description: Binary data

Reply via email to