Hi,

>From the code:
http://cvs.openssl.org/fileview?f=openssl/crypto/ecdsa/ecdsatest.c&v=1.35

I think the "if (tmp)" check from the fbytes method could be
eliminated since it contains a quite redundant checking.

"tmp" is allready dereferenced previously inside those 2 functions:
if (num != BN_num_bytes(tmp) || !BN_bn2bin(tmp, buf))

Speaking of which, the free method checks the variable, argument
against NULL, anyway...
void BN_free(BIGNUM *a)
{
    if (a == NULL) return;
...

Please englighten me if I am mistaken about it and thank you in advance ! :-)

Best Regards,
Laszlo Papp
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [email protected]
Automated List Manager                           [email protected]

Reply via email to