On Thu, Apr 07, 2011, Laszlo Papp wrote: > Hi, > > >From the code: > http://cvs.openssl.org/fileview?f=openssl/ssl/s23_clnt.c&v=1.50 > > I think the "if (s->s3 != NULL) check from the ssl23_get_server_hello > method could be > eliminated since it contains a quite redundant checking. > > "s->s3" is already dereferenced previously. > > [code] > memcpy(s->s2->challenge, > &(s->s3->client_random[SSL3_RANDOM_SIZE-i]),i); > > if (s->s3 != NULL) ssl3_free(s); > [/code] > > Speaking of which, the free method checks the variable, argument > against NULL, anyway... > > [code] > void ssl3_free(SSL *s) > { > if(s == NULL) > return; > ... > [/code] >
Could you send these to the request tracker for reasons mentioned in: http://www.openssl.org/support/faq.html#BUILD17 Steve. -- Dr Stephen N. Henson. OpenSSL project core developer. Commercial tech support now available see: http://www.openssl.org ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
