> [[email protected] - Thu Jul 14 14:45:17 2011]: > > This version improves compatibility with Solaris and Linux and > resolves some minor issues. >
A couple of initial comments. As it stands I think this will break compilation on Windows when linking DLLs. The mkdef.pl scripts need updating to handle the new define and the relevant new functions places under that define in the headers. This is much easier if the normal mechanism when adding new features is followed. You use the construct OPENSSL_NO_SCTP instead of OPENSSL_SCTP and disable them by default in Configure. Then you would use enable-sctp on the Configure command line to enable it. Also I notice direct structure accesses in several places: SSL_get_wbio(s)->method->type these should be avoided where possible. In this case you can avoid it by doing: BIO_method_type(SSL_get_wbio(s)) though if there is the possibility of a BIO chain being used here then you might want to examine that or use BIO_find_type instead. Perhaps include that in some ssl_is_sctp function or macro? Steve. -- Dr Stephen N. Henson. OpenSSL project core developer. Commercial tech support now available see: http://www.openssl.org ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
