Let's see if this subject gets it onto the list...

On Mon, Aug 12, 2013 at 8:48 AM, Anthony Foiani <anthony.foi...@gmail.com>wrote:

> Greetings.
>
> Someone on the #freenode openssl channel (cc'd) just commented on this
> bug, and I took a quick look.
>
> It seems it's a single-line patch (see bottom of message, and attached
> as well).  Results from top of master:
>
> $ without-patch/apps/openssl foo 2> /dev/null ; echo $?
> 0
>
> $ with-patch/apps/openssl foo 2> /dev/null ; echo $?
> 1
>
> (No idea if '1' is appropriate here, but I couldn't find any formal
> list of exit codes, so...)
>
> Thanks,
> Tony
>
> $ git log -1
> commit 5ae8d6bcbaff99423a2608559d738a3fcf7ed6dc
> Author: Kaspar Brand <ossl...@velox.ch>
> Date:   Tue Aug 6 16:01:47 2013 +0100
>
>     Fix for PEM_X509_INFO_read_bio.
>
>     PR: 3028
>     Fix bug introduced in PEM_X509_INFO_bio which wouldn't process RSA keys
>     correctly if they appeared first.
>
> $ git diff
> diff --git a/apps/openssl.c b/apps/openssl.c
> index 71e1e48..194c745 100644
> --- a/apps/openssl.c
> +++ b/apps/openssl.c
> @@ -607,7 +607,7 @@ static int do_cmd(LHASH_OF(FUNCTION) *prog, int
> argc, char *argv[])
>  #endif
>                         }
>                 BIO_printf(bio_err,"\n\n");
> -               ret=0;
> +               ret=1;
>                 }
>  end:
>         return(ret);
>

Attachment: 0001-Return-failure-exit-code-for-invalid-commands.patch
Description: Binary data

Reply via email to