Hello there,

I just ran the static analyser cppcheck over the source code
of openssl-1.0.1e

It said many things, including

1.

[s3_srvr.c:1842]: (style) Array index 'i' is used before limits check.

Source code is

        for (i=0; r[i] != NULL && i<4; i++)

Maybe

        for (i=0; (i < 4) && (r[i] != NULL); i++)

might be better code.

2.

[s3_srvr.c:1878]: (style) Array index 'i' is used before limits check.

Duplicate. 

I also checked the latest source code and the bugs seem to exist
there also.

Regards

David Binderman                                           
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [email protected]
Automated List Manager                           [email protected]

Reply via email to