From: "Dr. Stephen Henson" <st...@openssl.org>

> Patch applied. Let me know of any problems.

   Thanks.  Sadly, I forgot one refinement, which would keep the warning
from the test out of the log.  If I could talk you into smoothing over
that blunder, then I'd be able to rest easy (for a while).

--- ssl/ssl-lib.com;-1  2014-04-07 15:18:26 -0500
+++ ssl/ssl-lib.com     2014-04-07 18:26:49 -0500
@@ -1024,6 +1024,8 @@
 $   THEN
 $!    Not all compiler versions support MAYLOSEDATA3.
 $     OPT_TEST = "MAYLOSEDATA3"
+$     DEFINE /USER_MODE SYS$ERROR NL:
+$     DEFINE /USER_MODE SYS$OUTPUT NL:
 $     'CC' /NOCROSS_REFERENCE /NOLIST /NOOBJECT -
        /WARNINGS = DISABLE = ('OPT_TEST', EMPTYFILE) NL:
 $     IF ($SEVERITY)

   Sorry about the extra bother.


   For the record (no action required (or even requested)), the only
remaining compiler warnings were:

                if (timeleft.tv_sec < 0)
....................^
%CC-I-QUESTCOMPARE, In this statement, the unsigned expression
 "timeleft.tv_sec" is being compared with a relational operator to a
 constant whose value is not greater than zero.  This might not be what
 you intended.
at line number 310 in file 
ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.crypto.bio]bss_dgram.c;1

   Around here, time_t tends to be unsigned.


        if (*outlen <= 0)
............^
%CC-I-QUESTCOMPARE, In this statement, the unsigned expression "*outlen"
is being compared with a relational operator to a constant whose value
is not greater than zero.  This might not be what you intended.
at line number 180 in file
ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.engines.ccgost]gost94_keyx.c;1

   Around here, size_t tends to be unsigned.


                        if (size <= 0 || ((len = data[0])) != (size -1))
............................^
%CC-I-QUESTCOMPARE, In this statement, the unsigned expression "size" is
 being compared with a relational operator to a constant whose value is
 not greater than zero.  This might not be what you intended.
at line number 1128 in file
ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.ssl]t1_lib.c;1

   Here, "size" seems to be declared as unsigned:
        unsigned short size;
making the "< 0" part of that test pointless everywhere.

   These are all Informational ("-I-") complaints, so they cause less
trouble than a real warning ("-W-").

------------------------------------------------------------------------

   Steven M. Schweda               sms@antinode-info
   382 South Warwick Street        (+1) 651-699-9818
   Saint Paul  MN  55105-2547
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           majord...@openssl.org

Reply via email to