>> As for what to do. As far as I recall the "tangible" reason for redefine was >> that [by 1300 time] definition depended on compiler command line options (or >> wasn't a call to function). If definition does not depend on command line >> *now*, >> *and* always resort to function call, then it would be appropriate to to add >> "&& >> _MSC_VER<1900", or in fact whichever version when it became invariant. I >> don't >> have possibility to check >> MSVC14 for time being, but it seems to be case already in MSC10 or >> _MSC_VER==1600. Could you double-check MSCV14, while I do some testing with >> earlier version? > > The definition almost certainly depended on the version of the CRT up until > VC14, since FILE was a public type. As of 14.0, FILE is an opaque type and > the public definition won't be changing again (for the foreseeable future). > It definitely does not depend on command line flags anymore. > > I don't have any special insight into earlier versions of VC, but since they > seem to work fine I'd view disabling this for VC14+ only as the safer option. > Of course, you're free to do the research and make the changes, but if nobody > else has mentioned it then I'm sure it's fine.
http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429 I've chosen _MSC_VER<1600, because that what I explicitly verified. I've also verified 1700 and see no reason to believe that 1800 would be different. Case it being dismissed. ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
