Thank you for the comment - I have moved the new field at the end of the 
TS_RESP_CTX structure.
I have also introduced TS_SIGNING_DIGEST flag that should prevent binary 
compatibility issues when application allocates TS_RESP_CTX itself using older 
headers but uses a newer library - you have mentioned this potential problem in 
#3285.
Patch was tested against master branch.

Regards, Jaroslav

-----Original Message-----
From: Stephen Henson via RT [mailto:[email protected]]
Sent: Wednesday, July 2, 2014 10:18 PM
To: Imrich Jaroslav
Cc: [email protected]
Subject: [openssl.org #2145] [PATCH] New parameter "signing_digest" for TS 
module

On Wed Jul 02 20:48:55 2014, [email protected] wrote:
> I have cleaned the patch from unnecessary whitespace changes.
>

Thanks. I can see that you added a new field in the middle of a structures. For 
binary compatibiity reasons new fields can only go at the end of structures.

Steve.
--
Dr Stephen N. Henson. OpenSSL project core developer.
Commercial tech support now available see: http://www.openssl.org


Attachment: ts_signing_digest_20140703.patch
Description: Binary data

Reply via email to