This post is really a minor detail, but - given code is not largely documented - i would expect comments even minor to be accurate.
in ssl_lib.c line 2829 i read : /* For the next 2 functions, SSL_clear() sets shutdown and so * one of these calls will reset it */ functions are : void SSL_set_accept_state(SSL *s) and void SSL_set_connect_state(SSL *s) I think comment can be removed or should be reviewed since looking in code s->shutdown is actualy cleared correctly by SSL_clear(), so if it should be reset to 0 it is not due to SSL_clear(). neither void ssl2_clear(SSL *s) void ssl3_clear(SSL *s) void tls1_clear(SSL *s) void dtls1_clear(SSL *s) seems to modify shutdown field either. And looking in git, this is not new : commit 413c4f45 that resets it to 0 in SSL_clear() is 1999-02-16 10:22:21. So this comment is really obsolete, outdated and misleading. ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List [email protected] Automated List Manager [email protected]
