Am 10.04.2015 um 18:28 schrieb Viktor Dukhovni:
The branch master has been updated
via 34b0a927ab5c9232bcf864d524a9bf2558411700 (commit)
from e71cecd551f1d8beca20681184d94f7000a5e333 (commit)
- Log -----------------------------------------------------------------
commit 34b0a927ab5c9232bcf864d524a9bf2558411700
Author: Viktor Dukhovni <[email protected]>
Date: Fri Apr 10 12:25:30 2015 -0400
Polish shell script to avoid needless complexity.
No need for here documents, just use "yes" or </dev/null.
No need for "|| exit 1" clauses, just use "set -e".
Reviewed-by: Rich Salz <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
test/testca | 32 +++++++++-----------------------
1 file changed, 9 insertions(+), 23 deletions(-)
diff --git a/test/testca b/test/testca
index d4d0159..4bcb1fd 100644
--- a/test/testca
+++ b/test/testca
@@ -1,5 +1,7 @@
#!/bin/sh
So this is a /bin/sh script, not necessarily bash or ksh, and thus ...
@@ -9,35 +11,19 @@ else
fi
export PATH
-SSLEAY_CONFIG="-config CAss.cnf"
-export SSLEAY_CONFIG
-
-OPENSSL="`pwd`/../util/opensslwrap.sh"
-export OPENSSL
+export SSLEAY_CONFIG="-config CAss.cnf"
+export OPENSSL="`pwd`/../util/opensslwrap.sh"
...
-SSLEAY_CONFIG="-config Uss.cnf"
-export SSLEAY_CONFIG
-$PERL ../apps/CA.pl -newreq || exit 1
+export SSLEAY_CONFIG="-config Uss.cnf"
+$PERL ../apps/CA.pl -newreq
SSLEAY_CONFIG="-config ../apps/openssl.cnf"
-export SSLEAY_CONFIG
-
Combining
X=Y
export X
into
export X=Y
does not work for all plain Shells. E.g. /bin/sh on Solaris is a Bourne
Shell, which does not support this shortcut:
$ export X=Y
X=Y: is not an identifier
Regards,
Rainer
_______________________________________________
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
