On Fri, 2016-07-08 at 19:13 +0000, Viktor Dukhovni wrote: > > Perhaps rename dtls_ver_cmp() to dtls_ver_ordinal(), "cmp" suggests > that you're actually doing a comparison.
Well, 'cmp' with one argument isn't *so* easily interpreted as a comparison, but OK :) I've also added a comment explaining a little about what's going on. > Given this macro, one > might consider complementing the versions, so that the ordinals > compare in the usual way: > > #define dtls_ver_ordinal(v) (((v) == DTLS1_BAD_VER) ? 0x00ff : (0xffff ^ > (v))) I suppose we can, if someone feels strongly about it. It didn't seem worth the additional churn. One of 4 patches in https://github.com/openssl/openssl/pull/1296 which actually make OpenConnect work again... -- David Woodhouse Open Source Technology Centre david.woodho...@intel.com Intel Corporation
smime.p7s
Description: S/MIME cryptographic signature
-- openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
