When someone with write access to the main repo makes a PR and it gets approved, we usually wait for the person to do the final merge. This is perfectly fine to expect from us who are so called fellows, i.e. who are payed directly to work on OpenSSL... but to ask this of everyone else, when their $DAYJOB may suck them into something entirely different at any given time? I think that may be quite unfair, and is bad for the project.
So I think it's time we address this cultural thing (*), and also perhaps take a closer look at PRs that have been left hanging for this reason, and take it upon ourselves to help each other merge when we notice that it doesn't happen on its own. Cheers, Richard (*) It appears to be deep seated... there have been times when I knew I was going to be away, and said that anyone is free to merge a PR I submitted when it's approved, and it still didn't happen before I was back and did it myself.
--- Begin Message ---I see no reason not to merge this. It's been approved a long time ago, and the discussion that followed only clarifies the semantics, so... I know that @ekasper is quite busy elsewhere, so I'll merge now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openssl/openssl/pull/4955#issuecomment-382640850
--- End Message ---
_______________________________________________ openssl-project mailing list [email protected] https://mta.openssl.org/mailman/listinfo/openssl-project
