Hey I made the list! https://review.openstack.org/#/c/25355/
Just wanted to point out for nova in longest-waiting reviews based on first revision: 1. 94 days, 12 hours, 49 minutes - https://review.openstack.org/25355 (PowerVM resize and migrate test cases) This one is a bit skewed because it was abandoned due to inactivity and then I picked it back up by assigning the bug to myself and contributing to the original review. Is there a way to take that into account in the metrics? Or is this a process issue, i.e. should I have left this abandoned and pushed up a new review based on the original? Thanks, MATT RIEDEMANN Advisory Software Engineer Cloud Solutions and OpenStack Development Phone: 1-507-253-7622 | Mobile: 1-507-990-1889 E-mail: [email protected] 3605 Hwy 52 N Rochester, MN 55901-1407 United States From: Russell Bryant <[email protected]> To: OpenStack Development Mailing List <[email protected]>, Date: 06/27/2013 09:45 PM Subject: [openstack-dev] [Metrics][Nova] Another take on review turnaround stats Greetings, The key metric I have been using for knowing whether we are keeping up with review requests is the average wait time for getting a review. In a previous thread, we set a goal of keeping that under 4 days (at least by the end of the week, may be higher after a weekend). This is calculated using the time that the *latest* patch revision was posted. We have been keeping up with this (Nova at 3.5 days right now). I've been getting a lot of complaints this week about review turnaround. It's important to me that we're doing this well, but action needs to be based on real data. One of the theories was that patches are having to be rebased a bunch, so they have been waiting longer than the stats say. True, but by how much? The answer is now in the stats: http://russellbryant.net/openstack-stats/all-openreviews.html The results are much better than I was afraid of. On average across all projects, patches waiting for review have an age of just under 14 days since they were first posted. Nova is below average, sitting at an average of just over 10 days. That doesn't seem bad at all, to me. So, if we have a problem, it's not Nova specific, at least. It's harder to set a goal for this metric since it's not entirely in the hands of reviewers like the other one. Suggestions for additional tweaks welcome. Thanks, -- Russell Bryant _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
<<image/gif>>
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
