On 07/04/2013 06:10 PM, Julien Danjou wrote: > On Thu, Jul 04 2013, Julie Pichon wrote: > >> "Thomas Goirand" <z...@debian.org> wrote: >>> Horizon seems to use python-selenium. The problem is that, in Debian, >>> this package is in the non-free repository. So I strongly suggest to not >>> use it for Havana. That otherwise would put Horizon into the contrib >>> repository of Debian (eg: not officially in Debian), or eventually, >>> remove any possibility to run the unit tests, which isn't nice. >> >> Why is Selenium considered non-free? The code is Apache-licensed, including >> the Python bindings. >> >> FWIW only a few of the unit tests use Selenium (and those that do, need to), >> and they're not run by default unless you set a flag to do so. > > Yes, that seems like a mistake from the Debian packager as far as I can > tell. There's nothing that requires it to be in non-free. > > (Cc'ing Sascha, the maintainer)
Well, see this: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636677 There are files not built from source. Also, when looking at the package, it seems that it isn't maintained as good as it deserves. #700061 was opened in 08 Feb 2013, and there's no answer at all from Sascha to this bug (which is RC). That well may have been the reason why this package was removed from testing on the 6th of march (according to the Debian pts). IMO, the maintainer should have at least answered to the bug. Anyway, what isn't explained in #636677, is what is non-free. So I had a look. To me, what is not built from source is what is in py/selenium/webdriver: there is a webdriver.xpi in the firefox folder. Though the maintainer should have write about it, so we don't have to double-guess (it should be clearly documented in debian/copyright). Which part of Selenium is in use in the unit testings of Horizon? Could we imagine that this part of the unit testing be made optional? Like for example, only if python-selenium is installed, or else the tests are gracefully skipped? Cheers, Thomas Goirand (zigo) _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
