Hi Sam, that's a great work and it will be for sure my default driver for my development environment.
I have a question: once the review will be approved and the code merged into master, do you plan to create a driver nova subteam as Xen, HyperV and others do? I would be glad to cooperate on it. On 29 August 2013 07:54, Sam Alba <sam.a...@gmail.com> wrote: > On Wed, Aug 28, 2013 at 9:12 AM, Sam Alba <sam.a...@gmail.com> wrote: > > Thanks a lot everyone for the nice feedback. I am going to work hard > > to get all those new comments addressed to be able to re-submit a new > > patchset today or tomorrow (the later). > > > > On Wed, Aug 28, 2013 at 7:02 AM, Russell Bryant <rbry...@redhat.com> > wrote: > >> On 08/28/2013 05:18 AM, Daniel P. Berrange wrote: > >>> On Wed, Aug 28, 2013 at 06:00:50PM +1000, Michael Still wrote: > >>>> On Wed, Aug 28, 2013 at 4:18 AM, Sam Alba <sam.a...@gmail.com> wrote: > >>>>> Hi all, > >>>>> > >>>>> We've been working hard during the last couple of weeks with some > >>>>> people. Brian Waldon helped a lot designing the Glance integration > and > >>>>> driver testing. Dean Troyer helped a lot on bringing Docker support > in > >>>>> Devstack[1]. On top of that, we got several feedback on the Nova code > >>>>> review which definitely helped to improve the code. > >>>>> > >>>>> The blueprint[2] explains what Docker brings to Nova and how to use > it. > >>>> > >>>> I have to say that this blueprint is a fantastic example of how we > >>>> should be writing design documents. It addressed almost all of my > >>>> questions about the integration. > >>> > >>> Yes, Sam (& any of the other Docker guys involved) have been great at > >>> responding to reviewers' requests to expand their design document. The > >>> latest update has really helped in understanding how this driver works > >>> in the context of openstack from an architectural and functional POV. > >> > >> They've been great in responding to my requests, as well. The biggest > >> thing was that I wanted to see devstack support so that it's easily > >> testable, both by developers and by CI. They delivered. > >> > >> So, in general, I'm good with this going in. It's just a matter of > >> getting the code review completed in the next week before feature > >> freeze. I'm going to try to help with it this week. > >> > > If someone wants to take another look at > https://review.openstack.org/#/c/32960/, we answered/fixed all > previous comments. > > > -- > @sam_alba > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev