Hi, 1.We used mvn to create tar.gz and I'll add documentation for that. 2. The command is simple: "parameter1='some_value1' ... parameterN='some_valueN' disk-image-create element1 ... elementM -o image_name". Some files in ~/.cache/image-create/ are owned by root (for example, it is file SHA256SUMS*). So, we need to use 'sudo' for cleaning this directory. 3. This script should not be run with itself. And the command "disk-image-create" should not be run with itself too.
Thanks, Ivan. 2013/9/3 Matthew Farrellee <[email protected]> > Long weekend here in the US, so I didn't get a chance to comment before > this was merged, so... > > Re Oozie - How did you create the oozie-3.3.2.tar.gz? > > Re sudo image-cache - That's not the case for me, the wget is run without > sudo. How are you running disk-image-create? > > Re DIB_work - it's best practice to use /tmp for temporary work, and > mktemp. This script running concurrently with itself will result in unknown > output. > > Best, > > > matt > > -------- Original Message -------- > Subject: Change in stackforge/savanna-extra[**master]: Add > diskimage-creating script, elements for mirrors > Date: Thu, 29 Aug 2013 14:37:36 +0000 > From: Ivan Berezovskiy (Code Review) <[email protected]> > Reply-To: [email protected] > CC: Sergey Lukjanov <[email protected]>, Dmitry Mescheryakov < > [email protected]>, Nadya Privalova < > [email protected]>, Matthew Farrellee <[email protected]> > > Ivan Berezovskiy has posted comments on this change. > > > Change subject: Add diskimage-creating script, elements for mirrors > ..............................**..............................**.......... > > > Patch Set 6: (16 inline comments) > > > ..............................**...................... > File diskimage-create/diskimage-**create.sh > Line 11: export OOZIE_DOWNLOAD_URL="http://**a8e0dce84b3f00ed7910-** > a5806ff0396addabb148d230fde09b**7b.r31.cf1.rackcdn.com/oozie-** > 3.3.2.tar.gz<http://a8e0dce84b3f00ed7910-a5806ff0396addabb148d230fde09b7b.r31.cf1.rackcdn.com/oozie-3.3.2.tar.gz> > " > We don't use custom tarball. It is our own tarbal. Please, show me link, > if you know, where I can download oozie with all binary files. > > > Line 15: if [ $str = 'NAME="Ubuntu"' ]; then > Package 'redhat-lsb' is not preinstalled in some Fedora images like cloud > image. So, we can't use this command. > In DIB you can see script 02-lsb ('https://github.com/** > openstack/diskimage-builder/**blob/master/elements/fedora/** > pre-install.d/02-lsb<https://github.com/openstack/diskimage-builder/blob/master/elements/fedora/pre-install.d/02-lsb>') > that install this package. > > Line 21: fi > Done > > > Line 24: sudo rm -rf /home/$USER/.cache/image-**create/* > Image caching execute under 'sudo'. You can try to delete images without > sudo and you'll see 'premission denied' > > Line 31: cd DIB_work > Why? This directory will be removed after creating images. > > > Line 41: export DIB_COMMIT_ID=`git show --format=%H | head -1` > https://github.com/stackforge/**savanna-extra/blob/master/** > elements/savanna-version/**install.d/01-savanna-version<https://github.com/stackforge/savanna-extra/blob/master/elements/savanna-version/install.d/01-savanna-version> > > Line 42: cd ../ > Done > > > Line 48: export SAVANNA_ELEMENTS_COMMIT_ID=`**git show --format=%H | head > -1` > https://github.com/stackforge/**savanna-extra/blob/master/** > elements/savanna-version/**install.d/01-savanna-version<https://github.com/stackforge/savanna-extra/blob/master/elements/savanna-version/install.d/01-savanna-version> > > Line 49: cd ../ > Done > > Line 64: fi > We can't use 'lsb_release' as I said before. > > > ..............................**...................... > File diskimage-create/README.rst > Line 7: 1. If you want to change build parameters, you should edit this > script at 'export' commands. > Done > > > Line 9: 2. If you want to use your local mirrors, you can specify urls for > Fedora and Ubuntu mirrors using parameters 'FEDORA_MIRROR' and > 'UBUNTU_MIRROR' like this: > Done > > > Line 15: 3. If you want to add your element to this repository, you should > edit this script in your commit (you should export variables for your > element and add name of element to variables 'element_sequence'). > Done > > > ..............................**...................... > File elements/apt-mirror/root.d/0-**check > Line 2: if [ -z "$UBUNTU_MIRROR" ]; then > Done > > > ..............................**...................... > File elements/yum-mirror/root.d/0-**check > Line 2: if [ -z "$FEDORA_MIRROR" ]; then > Done > > > ..............................**...................... > File README.rst > Line 10: * Script for creating Fedora and Ubuntu cloud images with our > elements and default parameters. You should run command only: > Done > > > -- > To view, visit > https://review.openstack.org/**43916<https://review.openstack.org/43916> > To unsubscribe, visit > https://review.openstack.org/**settings<https://review.openstack.org/settings> > > Gerrit-MessageType: comment > Gerrit-Change-Id: I12632b5cee42b1dbfd79b7b7c3a7b**26962ace625 > Gerrit-PatchSet: 6 > Gerrit-Project: stackforge/savanna-extra > Gerrit-Branch: master > Gerrit-Owner: Ivan Berezovskiy <[email protected]> > Gerrit-Reviewer: Dmitry Mescheryakov <[email protected]> > Gerrit-Reviewer: Ivan Berezovskiy <[email protected]> > Gerrit-Reviewer: Jenkins > Gerrit-Reviewer: Matthew Farrellee <[email protected]> > Gerrit-Reviewer: Nadya Privalova <[email protected]> > Gerrit-Reviewer: Sergey Lukjanov <[email protected]> > > > > ______________________________**_________________ > OpenStack-dev mailing list > [email protected].**org <[email protected]> > http://lists.openstack.org/**cgi-bin/mailman/listinfo/**openstack-dev<http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev> >
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
