John S Warren/Raleigh/IBM@IBMUS wrote on 10/16/2013 03:38:05 PM:

> From: John S Warren/Raleigh/IBM@IBMUS
> To: OpenStack Development Mailing List 
<openstack-dev@lists.openstack.org>, 
> Date: 10/16/2013 03:42 PM
> Subject: Re: [openstack-dev] [oslo] i18n Message improvements
> 
> Doug Hellmann <doug.hellm...@dreamhost.com> wrote on 10/16/2013 03:11:12 
PM:
> 
> 
> > 
> > This doesn't quite match my understanding. 
> > 
> > IIUC, approach 1 was taken during havana and the resulting class did
> > not behave enough like a string to work everywhere (specifically, 
> > with logging for locales that did not use UTF-8 or ASCII encoding), 
> > so the feature was disabled at the last minute. 
> 
> Approach 1 includes extending the built-in text type (e.g. unicode), 
> which is not what was done in Havana, and is an alternative way of 
> addressing the logging issue.  In addition to fixing the logging 
> issue, extending the built-in text type would eliminate the need to 
> override a lot of the standard string-manipulation methods that are 
> being overridden in the current Message implementation.  I'm not sure 
> if that's what the term "magic" referred to in the meeting 
> discussion, but it's something that bothers me about the status quo. 
> 
> Thanks for your reply, 
> 
> John Warren_______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

I should have mentioned that approach 1 is implemented here:
https://review.openstack.org/#/c/46553 and has been tested in Glance
and Nova, so it is known to solve the logging problem that caused
lazy translation to be shut off.  I'm not claiming it couldn't do
with some polishing, but it does work.

Thanks,

John Warren
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to