If someone takes effort to learn Vim to the point when he/she develops code in it, they most definitely have their preferred settings already, why overwrite them? If those settings conflict with the style guide -- it has been said, pep8 and hacking check will notify.
I always thought that leaving some hints to text editor by adding specific content to file content is just a dirty hack -- files should not be editor agnostic, the editor should be smart enough to figure everything out by himself. And yeah, also a happy Vim user for 4 years. Replacing the long paragraph with a short response: +1, remove them :) On Fri, Oct 25, 2013 at 4:45 PM, Vishvananda Ishaya <vishvana...@gmail.com>wrote: > Interesting Background Information: > > Why do we have modelines? > > Termie put them in all the files of the first version of nova > > Why did he put in modelines instead of configuring his editor? > > Termie does a lot of python coding and he prefers a tabstop of 2 on all > his personal projects[1] > > I really don't see much value outside of people who prefer other tabstops > > +1 to remove them > > Vish > > [1] https://github.com/termie/git-bzr-ng/blob/master/git-bzr > On Oct 24, 2013, at 5:38 AM, Joe Gordon <joe.gord...@gmail.com> wrote: > > Since the beginning of OpenStack we have had vim modelines all over the > codebase, but after seeing this patch > https://review.opeenstack.org/#/c/50891/<https://review.openstack.org/#/c/50891/>I > took a further look into vim modelines and think we should remove them. > Before going any further, I should point out these lines don't bother me > too much but I figured if we could get consensus, then we could shrink our > codebase by a little bit. > > Sidenote: This discussion is being moved to the mailing list because it 'would > be better to have a mailing list thread about this rather than bits and > pieces of discussion in gerrit' as this change requires multiple patches. > https://review.openstack.org/#/c/51295/. > > > Why remove them? > > * Modelines aren't supported by default in debian or ubuntu due to > security reasons: https://wiki.python.org/moin/Vim > * Having modelines for vim means if someone wants we should support > modelines for emacs ( > http://www.gnu.org/software/emacs/manual/html_mono/emacs.html#Specifying-File-Variables) > etc. as well. And having a bunch of headers for different editors in each > file seems like extra overhead. > * There are other ways of making sure tabstop is set correctly for python > files, see https://wiki.python.org/moin/Vim. I am a vIm user myself and > have never used modelines. > * We have vim modelines in only 828 out of 1213 python files in nova > (68%), so if anyone is using modelines today, then it only works 68% of the > time in nova > * Why have the same config 828 times for one repo alone? This violates > the DRY principle (Don't Repeat Yourself). > > > Related Patches: > https://review.openstack.org/#/c/51295/ > > https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:noboilerplate,n,z > > best, > Joe > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Sincerely, Ruslan Kiianchuk.
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev