Agreed that any -1's should require a suggestion for a way to resolve the issue. I haven't seen people -1'ing without suggestions for improvement though. I think, generally, people help explain why a change is needed.
Jay S. Bryant
Linux Developer -
OpenStack Enterprise Edition
Department 7YLA, Building 015-2, Office E125, Rochester, MN
Telephone: (507) 253-4270, FAX (507) 253-6410
TIE Line: 553-4270
E-Mail: [email protected]
--------------------------------------------------------------------
All the world's a stage and most of us are desperately unrehearsed.
-- Sean O'Casey
--------------------------------------------------------------------
From: Ben Nemec <[email protected]>
To: [email protected],
Date: 11/11/2013 02:05 PM
Subject: Re: [openstack-dev] [qa] Policy on spelling and grammar
On 2013-11-11 13:28, Tim Bell wrote:
> As a speaker of the Queen's English, I find flavor to be incorrect.
> Does that mean I can -1 any patch that does not use flavour ?
>
> At CERN, we are working with 130 countries in a single community. The
> value of the contribution of non-english speakers far exceeds the
> occasional misunderstandings.
>
> Giving grammar/spellings -1 excludes major sections of the community
> from contribution.
>
> As our aim is meritocracy (in python, computer architecture and design
> rather than spelling), I'd propose
>
> - If someone identifies a need for clarification/correction as part of
> a review, they also submit the replacement text rather than just -1.
> - The submitter incorporates that change into a patch
Agreed. Whenever possible, a grammar/spelling -1 should include
proposed alternatives (I say whenever possible because I've -1'd a few
changes where the docstrings were incomprehensible to me, so I couldn't
provide a better alternative as I wasn't sure what they were trying to
say :-).
-Ben
_______________________________________________
OpenStack-dev mailing list
[email protected]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
<<image/jpeg>>
_______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
