On Fri, 2013-11-22 at 16:24 +0000, Duncan Thomas wrote: > On 22 November 2013 14:59, Ben Nemec <openst...@nemebean.com> wrote: > > > One other thought I had was to add the ability to split one Oslo sync up > > into multiple commits, either one per module, or even one per Oslo commit > > for some really large module changes (I'm thinking of the 1000 line db sync > > someone mentioned recently). It would be more review churn, but at least it > > would keep the changes per review down to a more reasonable level. I'm not > > positive it would be beneficial, but I thought I'd mention it. > > Cinder (often but not always me) tends to reject merges that do more > that one module at a time, because it makes it far harder to review > and spot problems, so some from of automation of this would be great.
Yes, it's good practice to sync related changes in individual commits, rather than one big oslo sync. An example from a previous sync I did in Cinder: https://review.openstack.org/#/c/12409/ (cfg) https://review.openstack.org/#/c/12411/ (zmq) https://review.openstack.org/#/c/12410/ (notifier) https://review.openstack.org/#/c/12412/ (misc) These were all proposed at the same time, but I split related notable changes into their own commits and then had a "misc" sync for more trivial stuff. Mark. _______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
