> -----Original Message----- > From: Hayes, Graham [mailto:graham.ha...@hpe.com] > Sent: 23 February 2017 03:25 > To: OpenStack Development Mailing List (not for usage questions) > <openstack-dev@lists.openstack.org> > Subject: Re: [openstack-dev] [qa] Tempest Stable plugin interface change > broke gate > > On 21/02/2017 15:25, Andrea Frittoli wrote: > > Hi Graham, > > > > sorry about that, and good catch. > > You are right, that's a stable interface so that change should not > > have landed. > > > > andrea > > > > On Tue, Feb 21, 2017 at 2:51 PM Hayes, Graham <graham.ha...@hpe.com > > <mailto:graham.ha...@hpe.com>> wrote: > > > > Hi. > > > > https://review.openstack.org/#/c/434304/ landed yesterday, which was > a > > change to the stable interface for tempest plugins. > > > > It also took out the designate gate. > > > > Is this interface stable? - If so, there should have been at least some > > deprecation cycle, notification, or something. > > > > Revert has been proposed - > > https://review.openstack.org/#/c/436612/ > > > > Can someone clarify what the "stable" in "Stable APIs" listed here [1] > > means? > > > > - Graham > > > > 1 - > > > > https://docs.openstack.org/developer/tempest/plugin.html#stable- > tempes > > t-apis-plugins-may-use > > > > > __________________________________________________________ > ________________ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: > > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > <http://OpenStack-dev- > requ...@lists.openstack.org?subject:unsubscribe> > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > The revert above still hasn't merged. > > The QA team blocked a change that updated HTTP status code, but removed > a stable interface with no deprecation. > > The revert needs to land, now, and then the QA team can debate > deprecation / removal.
Sorry about that. We are ok with that patch to merge that and yes we should do that with deprecation warning etc. > > To stop this happening in the future, can we get tempest to gate on some > tempest plugins? > > Just a gate job that runs when any code in the designated stable sections of > tempest change would be incredibly useful. That might be difficult to run lot of plugins tests on job for tempest stable interface but yes I agree with idea and we should have some mechanism to block the removal of stable interface without deprecation etc. Let's us think about more on this. > > Thanks, > > Graham > > __________________________________________________________ > ________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: OpenStack-dev- > requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev