On 12-Apr 15:25, Rodrigo Duarte wrote: > On Wed, Apr 12, 2017 at 2:47 PM, David Stanek <[email protected]> wrote: > > > On 12-Apr 14:30, Rodrigo Duarte wrote: > > > Just to illustrate the discussion, we have a bug fix that currently tries > > > to drop a FK between the federation and identity subsystems [1]. > > > > > > [1] https://review.openstack.org/#/c/445505/ > > > > I think this highlights one of my problems with the current architecture. > > I see that > > you've removed the FK and added delete logic to do what the data layer > > would be doing > > for you. I didn't see any added get_user() checks to make sure the user_id > > being used > > in creates/updates is valid. Are we already checking that somewhere else > > or is this > > introducing a new bug? > > > > The review [1] is dropping the idp_id and idp_id + protocol_id FKs, not the > user_id one. >
Right, misremembered. Just run s/user_id/idp_id/ and s/get_user/get_idp/ and you'll have the same issues. -- david stanek web: https://dstanek.com twitter: https://twitter.com/dstanek __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: [email protected]?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
